Opened 2 years ago

Closed 2 years ago

#5062 closed change (fixed)

[emscripten] Allow generation of custom bindings code

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29398655/

Description

Background

We currently implemented the awkward concept of "class initializers," currently used to create RegExpFilter.prototype.typeMap object and populate it with constants from C++. This is suboptimal as the same information could be added to the binding statically with much smaller impact on startup time.

What to change

Instead of class initializers, implement custom bindings generators - functions that will be called during bindings generation and can produce additional code. In case of RegExpFilter the complication is that this generation has to rely on data structures only available in the RegExpFilter.cpp file. This means that all C++ have to be processed in the bindings generation step, not merely bindings.cpp.

Change History (4)

comment:1 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by trev

  • Summary changed from Allow generation of custom bindings code to [emscripten] Allow generation of custom bindings code

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5062 - [emscripten Allow generation of custom bindings code]

comment:4 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.