Opened 20 months ago

Last modified 2 days ago

#5066 new change

Don't download subscription when connection parameters are inappropriate

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, vickyyu, erikvold Blocked By:
Blocking: #5182 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


Some libadblockplus users are asking about the functionality reducing the traffic usage for example when connection is metered or not Wi-Fi. Working with one of the users it had been decided to have an option to don't update subscriptions in certain circumstances.

High-level overview

Because of complexity and uniqueness on each platform of network system, its available API and application UI it's better to place the most part of details to platform specific projects which can provide the core with an asynchronous function "returning" Boolean indicating whether the current connection is suitable for downloading of a subscription.

Additional notes

  • there should be an API reflecting the reason subscription has not been updated for better UX, e.g. a distinguishable error code, not merely unknown error.
  • the API should support manual forcing of subscription update disregarding the circumstances
  • just in case, it should not concern all network requests, other requests, e.g. to notification.json should continue to work.

Please file corresponding issue for core.

Change History (4)

comment:1 Changed 20 months ago by fhd

  • Component changed from Unknown to Libadblockplus
  • Description modified (diff)
  • Keywords meta removed
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from [meta] Don't download subscription when connection parameters are inappropriate to Don't download subscription when connection parameters are inappropriate

comment:2 Changed 19 months ago by sergz

  • Blocking 5182 added

comment:3 Changed 11 months ago by fhd

  • Cc trev removed

comment:4 Changed 2 days ago by erikvold

  • Cc erikvold added
Note: See TracTickets for help on using tickets.