Opened 9 months ago

Closed 9 months ago

Last modified 6 months ago

#5077 closed change (fixed)

Update buildtools dependency to 1ed9c0c32f78

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian Blocked By: #5060, #5078
Blocking: #5080 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29399577/

Description (last modified by sebastian)

Background

Once the improvements (#5060, #5078) to our module packaging system in buildtools changes have landed we'll need to update the buildtools dependency in adblockpluschrome.

Our changes will be included:

This update pulls in one more change, which however, has no effect on the Chrome builds whatsoever:

What to change

  • Update the buildtools dependency to 1ed9c0c32f78.
  • Remove lib/info.js from metadata.common.
  • Remove the "Module framework stuff" section from lib/compat.js.
  • Add the new injectinfomodule option for files in the convert_js section which want to use the info module

Hints for testers

  • Ensure both the WebExtension and Chrome extension seem to work properly. Check for exceptions in the developer console (background console for Chrome). If something has gone wrong it should be very obvious!

Change History (13)

comment:1 Changed 9 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 9 months ago by kzar

  • Blocked By 5078 added

comment:3 Changed 9 months ago by kzar

  • Blocking 5080 added

comment:4 Changed 9 months ago by kzar

  • Blocking 4864 removed

comment:5 Changed 9 months ago by sebastian

  • Blocking 5084 added

comment:6 Changed 9 months ago by kzar

  • Description modified (diff)
  • Summary changed from Update buildtools dependency to 5060-modules to Update buildtools dependency to 5078-modules

comment:7 Changed 9 months ago by sebastian

  • Blocking 5084 removed

comment:8 Changed 9 months ago by kzar

  • Description modified (diff)

comment:9 Changed 9 months ago by kzar

  • Description modified (diff)
  • Summary changed from Update buildtools dependency to 5078-modules to Update buildtools dependency to 1ed9c0c32f78

comment:10 Changed 9 months ago by sebastian

  • Description modified (diff)

comment:11 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 5077 - Update buildtools dependency to 1ed9c0c32f78

comment:12 Changed 9 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:13 Changed 6 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

The extension generally looks okay and no obvious errors occur (such as in the background console).

ABP 1.13.2.1785
Firefox Dev 55.0b5 / Windows 7
Chrome 49 / 59 / Windows 7
Opera 39 / 45 / Windows 7

Note: See TracTickets for help on using tickets.