Opened 3 years ago

Closed 3 years ago

#5078 closed change (rejected)

Allow convert_js to combine files which have already been processed

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: #5077 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29399582/

Description

Background

For #4864 we want to start using proper modules for the content scripts. To do that we need to use convert_js on some of them, one being elemHideEmulation.js. Since elemHideEmulation.js is itself a combination of some other files we need to be able to combine files which have already been processed / combined.

What to change

Tweak the convertJS logic in packagerChrome.py so that input files already in the files dictionary are not read again.

Change History (3)

comment:1 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 in reply to: ↑ description Changed 3 years ago by sebastian

  • Ready unset

We should include lib/common.js and chrome/content/elemHideEmulation.js from adblockpluscore as separate modules. So instead of changing buildtools here, we should just add const {filterToRegExp} = require('common'); to elemHideEmulation.js in adblockpluscore.

comment:3 Changed 3 years ago by kzar

  • Resolution set to rejected
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.