Changes between Version 15 and Version 17 of Ticket #5079


Ignore:
Timestamp:
08/16/2017 03:59:42 PM (3 years ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5079

    • Property Status changed from reopened to reviewing
  • Ticket #5079 – Description

    v15 v17  
    33 
    44=== What to change === 
    5 Rename `adblockpluscore/chrome/content/elemHideEmulation.js` into `adblockpluscore/lib/content/elemHideEmulation.js` and turn it into a proper CommonJS module exporting `ElemHideEmulation` and `splitSelector`. It should also call `require("common.js")` rather than expect this module to be loaded in global scope (common.js can export its symbols unconditionally then). Unit tests need to be adjusted as well. 
     5Rename `adblockpluscore/chrome/content/elemHideEmulation.js` into `adblockpluscore/lib/content/elemHideEmulation.js` and turn it into a proper CommonJS module exporting `ElemHideEmulation`. Move `splitSelector` into `adblockpluscore/lib/common.js` and export that too. Have `elemHideEmulation.js` call `require("common.js")` rather than expect it to be loaded in global scope (common.js can export its symbols unconditionally then). Unit tests need to be adjusted as well. 
    66 
    77=== Integration notes ===