Changes between Version 1 and Version 6 of Ticket #5079


Ignore:
Timestamp:
04/03/2017 08:00:51 AM (3 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5079

    • Property Priority changed from Unknown to P3
    • Property Blocking changed from 4864 to 5089
  • Ticket #5079 – Description

    v1 v6  
    33 
    44=== What to change === 
    5 Change `adblockpluscore/chrome/content/elemHideEmulation.js` to export `ElemHideEmulation` and `splitSelector` if possible. 
     5Rename `adblockpluscore/chrome/content/elemHideEmulation.js` into `adblockpluscore/lib/content/elemHideEmulation.js` and turn it into a proper CommonJS module exporting `ElemHideEmulation` and `splitSelector`. It should also call `require("common.js")` rather than expect this module to be loaded in global scope (common.js can export its symbols unconditionally then). 
     6 
     7=== Integration notes === 
     8Make sure to adjust `elemHideEmulation` import to consider its new location. Also, it now needs to be used as a CommonJS module.