Opened 3 years ago

Last modified 3 years ago

#5079 closed change

Export ElemHideEmulation and splitSelector — at Version 6

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: sebastian, trev, hfiguiere, jsonesen Blocked By:
Blocking: #5089 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29399602/
https://codereview.adblockplus.org/29460576/
https://codereview.adblockplus.org/29517687/

Description (last modified by trev)

Background

We want to begin using modules for the adblockpluschrome content scripts too. This is so that we don't need to have so many /* globals ... */ comments now that we're using ESLint.

What to change

Rename adblockpluscore/chrome/content/elemHideEmulation.js into adblockpluscore/lib/content/elemHideEmulation.js and turn it into a proper CommonJS module exporting ElemHideEmulation and splitSelector. It should also call require("common.js") rather than expect this module to be loaded in global scope (common.js can export its symbols unconditionally then).

Integration notes

Make sure to adjust elemHideEmulation import to consider its new location. Also, it now needs to be used as a CommonJS module.

Change History (6)

comment:1 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by kzar

  • Blocking 5080 added

comment:3 Changed 3 years ago by kzar

  • Blocking 4864 removed

comment:4 Changed 3 years ago by kzar

  • Blocking 5089 added

comment:5 Changed 3 years ago by kzar

  • Blocking 5080 removed

comment:6 Changed 3 years ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P3
Note: See TracTickets for help on using tickets.