Opened 3 years ago

Last modified 3 years ago

#5080 closed change

Start using modules for the content scripts — at Initial Version

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: sebastian Blocked By: #4868, #5077, #5079
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29577555/

Description

Background

With the ESLint changes in #4868 we needed to add some /* globals ... */ comments in order to get things to pass. We now want to reduce those by breaking the content scripts into proper modules.

What to change

  • Combine the relevant content scripts by adding them to the convert_js second in metadata.common.. Make sure the "modules" argument is used. Make sure the "autoload" argument is used where required.
  • Export the globals used by others in those content scripts.
  • Require those exported globals.
  • Also require the things exported by lib/elemHideEmulation.js see #5079.
  • Remove those global comments.

Change History (0)

Note: See TracTickets for help on using tickets.