Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#5085 closed change (fixed)

Separate "info" module for Microsoft Edge from chromeInfo.js.tmpl

Reported by: sebastian Assignee: jsonesen
Priority: P3 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: kzar, jsonesen, oleksandr Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29454678/

Description

Background

With #3704 we begun to target Microsoft Edge in chromeInfo.js.tmpl, assuming that it will use the same builds as Chrome does, but in the end we had to implement a separate packager. As a result, we are now in the mess, that different build targets are handled in a different way, for no good reason, when it comes to their info module. Moreover, as there are separate builds for Microsoft Edge now anyway, it doesn't make much sense that we currently include the quite complex Chrome-specific logic there, which potentially even gives unnecessary inaccurate results when messing with the user agent string.

What to change

Split out the logic, targeting Microsoft Edge, from chromeInfo.js.tmpl into a new template edgeInfo.js.tmpl, and generate the info module for the Microsoft Edge builds from that new template.

Change History (5)

comment:1 Changed 3 years ago by jsonesen

  • Owner set to jsonesen

comment:2 Changed 3 years ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5085 - Add edgeInfo.info template for edge specific builds

comment:4 Changed 2 years ago by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Has not broken creating Chrome and Edge builds.

adblockpluschrome / 1846:44197859df84

Note: See TracTickets for help on using tickets.