Opened 3 years ago

Closed 3 years ago

#5086 closed change (fixed)

Add webrtc connection type

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev, sebastian Blocked By:
Blocking: #5087 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29401571/
https://codereview.adblockplus.org/29402586/

Description

Background

In #4455 we are hoping to support WebRTC blocking by wrapping the relevant APIs like we do for the WebSocket ones. Before we can do that we need to add a new request type for them.

What to change

Add the webrtc request type to the core code. Ensure the tests all still pass.

Change History (11)

comment:1 Changed 3 years ago by kzar

  • Blocking 5087 added

comment:2 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by kzar

  • Blocking 5091 added

comment:4 Changed 3 years ago by trev

  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 3 years ago by trev

  • Review URL(s) modified (diff)

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5086 - Add webrtc connection type

comment:7 Changed 3 years ago by kzar

  • Blocking 5091 removed

comment:8 Changed 3 years ago by kzar

  • Blocking 5124 added

comment:9 Changed 3 years ago by kzar

  • Blocking 5124 removed

comment:10 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5086 - Add webrtc request type

comment:11 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.