Opened 8 months ago

Closed 8 months ago

Last modified 4 months ago

#5087 closed change (fixed)

Update adblockpluscore dependency to 7c3a22c134db

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, Ross Blocked By: #5086
Blocking: #4455 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29401590/

Description (last modified by kzar)

Background

Once we have finished #5086 there will be a webrtc request type, but before we can use it we need to update the adblockpluscore dependency in adblockpluschrome to 7c3a22c134db.

Three other changes will be included:

All three relate to the filter storage code, the changes were necessary for migration of Firefox users to the WebExt extension.

What to change

Update the adblockpluscore dependency to the revision 7c3a22c134db.

Hints for testers

  • Ensure a filter with the request type option of $webrtc is allowed to be created.
  • Check that filter storage still works, that filters aren't lost after an upgrade or after restarting the extension or browser.

Change History (5)

comment:1 Changed 8 months ago by kzar

  • Description modified (diff)
  • Owner set to kzar
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from Update adblockpluscore dependency to 5086-webrtc-type to Update adblockpluscore dependency to 7c3a22c134db

comment:2 Changed 8 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 8 months ago by kzar

  • Cc Ross added
  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 8 months ago by kzar

A commit referencing this issue has landed:
Issue 4455, 5087, 5092 - Wrap RTCPeerConnection to allow blocking

comment:5 Changed 4 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Filter storage seems fine after restart/upgrade and $webrtc work as expected.

ABP 1.13.2.1785
Chrome 49 / 59 / Windows 7
Opera 37 / 45 / Windows 7

Note: See TracTickets for help on using tickets.