Opened on 04/03/2017 at 04:41:27 AM

Closed on 04/09/2017 at 04:39:26 AM

Last modified on 07/10/2017 at 03:29:37 PM

#5087 closed change (fixed)

Update adblockpluscore dependency to 7c3a22c134db

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, Ross Blocked By: #5086
Blocking: #4455 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


Once we have finished #5086 there will be a webrtc request type, but before we can use it we need to update the adblockpluscore dependency in adblockpluschrome to 7c3a22c134db.

Three other changes will be included:

All three relate to the filter storage code, the changes were necessary for migration of Firefox users to the WebExt extension.

What to change

Update the adblockpluscore dependency to the revision 7c3a22c134db.

Hints for testers

  • Ensure a filter with the request type option of $webrtc is allowed to be created.
  • Check that filter storage still works, that filters aren't lost after an upgrade or after restarting the extension or browser.

Attachments (0)

Change History (5)

comment:1 Changed on 04/08/2017 at 07:45:37 AM by kzar

  • Description modified (diff)
  • Owner set to kzar
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from Update adblockpluscore dependency to 5086-webrtc-type to Update adblockpluscore dependency to 7c3a22c134db

comment:2 Changed on 04/08/2017 at 07:50:42 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/09/2017 at 04:39:26 AM by kzar

  • Cc Ross added
  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 04/09/2017 at 04:40:37 AM by kzar

A commit referencing this issue has landed:
Issue 4455, 5087, 5092 - Wrap RTCPeerConnection to allow blocking

comment:5 Changed on 07/10/2017 at 03:29:37 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Filter storage seems fine after restart/upgrade and $webrtc work as expected.

Chrome 49 / 59 / Windows 7
Opera 37 / 45 / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.