Changes between Initial Version and Version 1 of Ticket #5087


Ignore:
Timestamp:
04/08/2017 07:45:37 AM (3 years ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5087

    • Property Owner set to kzar
    • Property Priority changed from Unknown to P2
    • Property Ready set
    • Property Summary changed from Update adblockpluscore dependency to 5086-webrtc-type to Update adblockpluscore dependency to 7c3a22c134db
  • Ticket #5087 – Description

    initial v1  
    11=== Background === 
    2 Once we have finished #5086 there will be a `webrtc` request type, but before we can use it we need to update the `adblockpluscore` dependency in `adblockpluschrome`. 
     2Once we have finished #5086 there will be a `webrtc` request type, but before we can use it we need to update the `adblockpluscore` dependency in `adblockpluschrome` to `7c3a22c134db`. 
     3 
     4Three other changes will be included: 
     5- [https://hg.adblockplus.org/adblockpluscore/rev/e8d5c4ca83bb Issue 5052 - Adjust filter storage unit tests for API changes] 
     6- [https://hg.adblockplus.org/adblockpluscore/rev/c8d4a462860a Issue 5052 - Allow importing and exporting filterStorage data without file access] 
     7- [https://hg.adblockplus.org/adblockpluscore/rev/387cff1ab5e0 Issue 5098 - Expose FilterStorage initialization state] 
     8 
     9All three relate to the filter storage code, the changes were necessary for migration of Firefox users to the WebExt extension. 
    310 
    411=== What to change === 
    5 Update the `adblockpluscore` dependency to the revision 5086-webrtc-type. 
     12Update the `adblockpluscore` dependency to the revision `7c3a22c134db`. 
     13 
     14=== Hints for testers === 
     15 - Ensure a filter with the request type option of `$webrtc` is allowed to be created. 
     16 - Check that filter storage still works, that filters aren't lost after an upgrade or after restarting the extension or browser.