Opened 3 years ago

Last modified 2 years ago

#5090 closed change

Switch to chrome.tabs.insertCSS() on Firefox — at Initial Version

Reported by: trev Assignee:
Priority: P2 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, greiner, Ross Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29410607/

Description

Background

As of Firefox 53, chrome.tabs.insertCSS implementation on Firefox accepts a cssOrigin parameter which makes it usable for us. Unlike with Chrome, on Firefox we can now inject CSS code from the background process directly without messing with the DOM in the content script.

What to change

Add a special code path when responding to get-selectors message - on Firefox 53 and higher no selectors should be returned, instead chrome.tabs.insertCSS should be called.

Change History (0)

Note: See TracTickets for help on using tickets.