Opened 3 years ago

Closed 20 months ago

#5093 closed change (rejected)

Indicate whether request in devtools panel belongs to tab

Reported by: greiner Assignee: agiammarchi
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: sebastian Blocked By: #6402
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29695580/

Description (last modified by greiner)

Background

Starting with #5042 the devtools panel will receive requests that were made from tabs without an ID. To avoid confusion we should visually differentiate those from requests originating from the tab that the devtools window is associated with.

What to change

Use different styles for requests from tabs without an ID in the devtools panel (see design proposal). Furthermore, we may want to provide information on how they are different and how they differ from regular requests but grouping them under "Requests from background tabs" should be sufficient for now.

Attachments (1)

devtools-anon-requests.png (49.9 KB) - added by greiner 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by sebastian

  • Cc sebastian added

Changed 3 years ago by greiner

comment:2 Changed 3 years ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 22 months ago by agiammarchi

  • Owner set to agiammarchi

comment:4 Changed 22 months ago by agiammarchi

  • Review URL(s) modified (diff)

comment:5 Changed 22 months ago by agiammarchi

  • Blocked By 6402 added

comment:6 Changed 20 months ago by greiner

Note that according to #6543, we'll be able to associate all requests with a domain starting with Chrome 63.

comment:7 Changed 20 months ago by sebastian

Yes, this can be closed now. Once #6543 and #6544 land, we won't log any requests without context information to the devtools panel anymore.

comment:8 Changed 20 months ago by agiammarchi

so if I understand correctly we don't care about informing older versions of the browser and I can abandon the codereview, right?

comment:9 follow-up: Changed 20 months ago by greiner

@Sebastian Does that mean that the DevTools panel won't receive any requests anymore that don't belong to the tab it inspects? Because from the ticket description this wasn't clear. If so, this ticket could be closed.

However, as Andrea pointed out, we may still want to add it to support older browser versions. What's your take on that?

comment:10 in reply to: ↑ 9 Changed 20 months ago by sebastian

With #6543, requests from Service/Shared Workers are associated with the document that caused the worker to spawn (on all versions of Firefox and Chromium >=63), and will only be logged to the devtools panel on pages controlled by that worker, with the respective origin indicated.

With #6544, we will ignore requests sent by the browser and the extension itself, which leaves no orphaned requests left on Firefox and Chromium >=63. However, as a side effect we will also stop processing requests that have been sent by Service/Shared Workers on Chromium <63 and Microsoft Edge, since those cannot be distinguished from requests sent by the browser or the extension itself.

comment:11 Changed 20 months ago by agiammarchi

  • Resolution set to rejected
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.