Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5099 closed defect (fixed)

Element Hiding Helper: Console errors when using view source in window

Reported by: Ross Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.4
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29402624/

Description

Environment

ABP 2.8.2
EHH 1.3.10.551-beta
Firefox 52 / Windows 7
(Also occurs when using ABP 2.8.2.4242-beta)

How to reproduce

  1. Start EHH element selection.
  2. Hover an element (any).
  3. Press U to view source of element hovered in a window.

Observed behaviour

The source is displayed in a new window as expected but the following errors also occur:

TypeError: state.selectedElement is undefined commands.js:50:5
Error: Must supply a URL when when opening view source ViewSourceBrowser.jsm:185:13

Expected behaviour

Errors not to occur.

Change History (7)

comment:1 Changed 2 years ago by trev

  • Owner set to trev

comment:2 Changed 2 years ago by trev

  • Priority changed from P3 to P1
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by trev

  • Milestone set to Element-Hiding-Helper-1.4
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by Ross

The TypeError is fixed but the error about supplying a URL still occurs. Is it ignorable? Everything seems to function as expected.

ABP 2.8.2
EHH 1.3.10.522-beta
Firefox 52 / Windows 7

comment:6 Changed 2 years ago by trev

Yes, that isn't our code. As long as the window actually opens the error should be fine.

comment:7 Changed 2 years ago by Ross

  • Verified working set

Fixed.

ABP 2.8.2
EHH 1.3.10.522-beta
Firefox 52 / Windows 7

Note: See TracTickets for help on using tickets.