Opened 3 years ago

Closed 22 months ago

Last modified 21 months ago

#5103 closed change (incomplete)

Add padding to 1/2 column images on acceptableads.com

Reported by: juliandoucette Assignee:
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: athornburgh, jeen, saroyanm, p.pastourmatzis Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

There are a couple images on acceptableads.com that look awkwardly wide.

What to change

Add a little padding around these images.

Change History (10)

comment:1 Changed 3 years ago by juliandoucette

I can do this myself if product approves.

comment:2 Changed 3 years ago by jeen

@juliandoucette I am not sure I understand what you mean by this? Are the images too large or the padding too wide?

comment:3 Changed 3 years ago by juliandoucette

@Jeen there is not enough padding left/right around these images. As a result (especially in example 2) the images appear too large IMO.

comment:4 Changed 3 years ago by jeen

@juliandoucette ah got you. Yes happy for you to go ahead and adjust the padding accordingly.

comment:5 Changed 3 years ago by juliandoucette

  • Priority changed from Unknown to P3
  • Ready set

comment:6 Changed 2 years ago by juliandoucette

  • Milestone acceptableads.com/committee cleanup deleted

comment:7 Changed 2 years ago by juliandoucette

  • Owner set to juliandoucette

comment:8 Changed 2 years ago by juliandoucette

  • Owner juliandoucette deleted

I would have unset codereview and removed this link if I added it in the first place.

comment:9 Changed 22 months ago by juliandoucette

  • Resolution set to incomplete
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.