Opened 6 years ago

Last modified 5 years ago

#510 closed change

[Typed objects] Don't hardcode script load order in unit tests — at Version 2

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #145 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4911523189227520/
http://codereview.adblockplus.org/4895499043733504/

Description

Background

Currently the unit tests hardcode the order in which the scripts from the lib/ directory need to load. Every time a new script is created it has to be added to the list in the right position.

What to change

Have the require() function add scripts dynamically so that the load order is determined implicitly.

Change History (2)

comment:1 Changed 6 years ago by trev

  • Owner set to trev

comment:2 Changed 6 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.