Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5110 closed change (fixed)

Update adblockpluscore dependency to revision 387cff1ab5e0

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29403747/

Description

Background

The changes in #5052 caused a regression, first-run actions running prematurely on update. We need #5098 in order to address this.

What to change

Update dependency and make sure !FilterStorage.initialized is used instead of FilterStorage._loading.

What to test

First-run page should not open on update and filter storage shouldn't be reinitialized (default subscription added) - unless there is really no data (adblockplus/patterns.ini removed and no backups). Note that this is really about the update scenario, you have to be updating from a previous development build.

First-run page should open as usual on initial installation and default subscriptions should be added.

Change History (4)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by Ross

  • Verified working set

Fixed. FRP does not appear and subscriptions/filters are not changed on update. Unless, there is no data, where they do appear/change (as described).

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Dev (54) / Windows 7

Note: See TracTickets for help on using tickets.