Changes between Version 1 and Version 2 of Ticket #5117


Ignore:
Timestamp:
04/06/2017 03:23:19 PM (3 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5117 – Description

    v1 v2  
    44With #3596, we added logic to deal with `ElemHideEmulationFilter`s, so that they show up in the devtools panel as well. For these kind of filters we cannot associate the generated selector with the original filter, however the actual filter text is available. But instead of passing the orginal filter through all the way to the devtools panel, we went with a more pragmatic approach and just extracted the selector part from the filter so that it works with the existing logic, introducing a slightly leaky abstraction. 
    55 
    6 Now, with #5049, we are going to integrate a new kind of `ElemHideEmulationFilter`s that don't generate a selector in the first place, but hides elements directly. In order to log these filters in the devtools panel, we have to skip the tracing functionality, and potentially end up duplicating the hack. 
     6Now, with #5049, we are going to integrate a new kind of `ElemHideEmulationFilter` that don't generate a selector in the first place, but hides elements directly. In order to log these filters in the devtools panel, we have to skip the tracing functionality, and potentially end up duplicating the hack. 
    77 
    88=== What to change ===