Opened 2 years ago

Closed 2 years ago

#5119 closed change (fixed)

use own version of buildtools for ensure_deps instead of a version from adblockpluscore

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd Blocked By:
Blocking: #4907 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29453708/

Description (last modified by sergz)

Background

In order to update v8 (#4907) we need to fix ensure_dependencies.py (#4906), however it won't be easy to also update adblockpluscore because the latter contains some incompatible changes and it would be better to not mix adaptation to these changes with updating of v8 which is already going to be not a small change. So the plan is to land #4906, then this issue, then #4907 and only afterwards update adblockpluscore.

What to change

Change dependencies file.

The changes concerning ensure_dependencies.py imported by this are:


changes without issues:

e120a0d93303Noissue - Adapt quotes for compliance with our coding styleSebastian Noack
0a21b061b2fbNoissue - Got rid of non-defualt script encodingsSebastian Noack

Change History (6)

comment:1 Changed 2 years ago by sergz

  • Blocking 4907 added
  • Owner set to sergz

comment:2 Changed 2 years ago by sergz

  • Description modified (diff)

It also implies updating of ensure_dependencies.py file, so I'm adding a list of relevant changes in buildtools repository since the commit referenced by adblockpluscore which is referenced by libadblockplus.

comment:3 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by sergz

  • Description modified (diff)

comment:6 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.