Opened on 04/06/2017 at 03:52:40 PM

Closed on 06/02/2017 at 06:50:16 AM

#5119 closed change (fixed)

use own version of buildtools for ensure_deps instead of a version from adblockpluscore

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd Blocked By:
Blocking: #4907 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)


In order to update v8 (#4907) we need to fix (#4906), however it won't be easy to also update adblockpluscore because the latter contains some incompatible changes and it would be better to not mix adaptation to these changes with updating of v8 which is already going to be not a small change. So the plan is to land #4906, then this issue, then #4907 and only afterwards update adblockpluscore.

What to change

Change dependencies file.

The changes concerning imported by this are:

changes without issues:

e120a0d93303Noissue - Adapt quotes for compliance with our coding styleSebastian Noack
0a21b061b2fbNoissue - Got rid of non-defualt script encodingsSebastian Noack

Attachments (0)

Change History (6)

comment:1 Changed on 06/01/2017 at 04:13:25 PM by sergz

  • Blocking 4907 added
  • Owner set to sergz

comment:2 Changed on 06/01/2017 at 04:51:31 PM by sergz

  • Description modified (diff)

It also implies updating of file, so I'm adding a list of relevant changes in buildtools repository since the commit referenced by adblockpluscore which is referenced by libadblockplus.

comment:3 Changed on 06/01/2017 at 04:57:00 PM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 06/01/2017 at 08:45:32 PM by sergz

  • Description modified (diff)

comment:5 Changed on 06/02/2017 at 06:48:23 AM by abpbot

comment:6 Changed on 06/02/2017 at 06:50:16 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.