Opened 3 years ago

Closed 2 years ago

Last modified 2 weeks ago

#5135 closed change (fixed)

Reduce font size and padding on smaller screens on acceptableads.com

Reported by: juliandoucette Assignee: ire
Priority: P2 Milestone: acceptableads.com/committee cleanup
Module: Websites Keywords: goodfirstbug
Cc: saroyanm, jeen, erick Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29438582

Description (last modified by juliandoucette)

Background

See https://issues.adblockplus.org/ticket/5105#comment:7

What to change

  • Reduce font size and padding around content on small screens.
    • Exact sizes to-be-defined in codereview.

Change History (10)

comment:1 Changed 3 years ago by juliandoucette

  • Priority changed from P3 to P5

Jeen should we wait for you to provide some guidance about the exact size and padding or should we wing it and ask for your approval?

comment:2 Changed 3 years ago by jeen

  • I would say for the header - bring it down by about 40% - but feel free to use your judgement. (Right now it is 42px, so perhaps down to 32px)
  • For the body text, don't go below 16px.

comment:3 Changed 3 years ago by juliandoucette

  • Description modified (diff)
  • Priority changed from P5 to P2
  • Ready set

I set P2 because:

  • This issue is pretty bad on small screens
  • This website often trends when AA and AAC get media attention

comment:4 Changed 2 years ago by ire

  • Owner set to iaderinokun

comment:5 Changed 2 years ago by ire

  • Status changed from new to reviewing

comment:6 follow-up: Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)

Put review url into "Review URL(s)".

comment:7 in reply to: ↑ 6 Changed 2 years ago by ire

Replying to juliandoucette:

Put review url into "Review URL(s)".

Okay.

comment:9 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 4 months ago by modifaku

spam

Last edited 2 weeks ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.