Opened 3 years ago

Closed 21 months ago

#5143 closed change (fixed)

[emscripten] Convert element hiding emulation container to C++

Reported by: trev Assignee: hfiguiere
Priority: P3 Milestone:
Module: Core Keywords:
Cc: oleksandr Blocked By:
Blocking: #4122, #5144 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29594607/

Description

Background

See #4122 for the rationale. For maximal performance, all operations involving filter text should stay within Emscripten - including elemHideEmulation container.

What to change

  • Implement ElemHideEmulation namespace (alternatively: class with default instance, like in #5141) exposing methods clear, add and remove to manage list of filters.
  • Implement getRulesForDomain method returning _ElemHideEmulation_FilterList object. This object should expose a filterCount property as well as filterAt method.

Change History (6)

comment:1 Changed 3 years ago by trev

  • Blocking 5144 added

comment:2 Changed 2 years ago by oleksandr

  • Cc oleksandr added

comment:3 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed 2 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 21 months ago by abpbot

A commit referencing this issue has landed:
Issue 5143 - Convert ElemHideEmulation to C++

comment:6 Changed 21 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.