Opened 3 years ago

Closed 3 months ago

Last modified 6 weeks ago

#5149 closed change (rejected)

[emscripten] Verify that unit tests don't leak any objects

Reported by: trev Assignee: tlucas
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: oleksandr, tlucas, sergz Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Now that we do "manual" garbage collection, it's important that we never forget to release object references.

What to change

Verify that by the end of each unit test all objects have been garbage collected. The trivial implementation would be adding a filter/subscription counter - global variables incremented in Filter/Subscription constructor and decremented in the corresponding destructor. At the end of each unit test these counters should have the value zero. A more generic solution would be desirable, maybe by using sandboxed-module to instrument some Emscripten code and track all objects exposed by bindings - question is whether this approach is feasible (normally this kind of instrumentation is done with a special build but we wouldn't want to require a special builds for tests).

Change History (4)

comment:1 Changed 2 years ago by oleksandr

  • Cc oleksandr tlucas added
  • Owner set to tlucas

comment:2 Changed 2 years ago by sergz

  • Cc sergz added

comment:3 Changed 3 months ago by yoyo9996

spam

Last edited 6 weeks ago by kzar (previous) (diff)

comment:4 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.