Opened on 04/18/2017 at 01:12:54 PM

Closed on 04/20/2017 at 08:19:54 AM

#5153 closed change (fixed)

Simplify patterns.ini parsing

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #4128 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)


In order to simplify the Emscripten implementation in #4128, we should change the current parsing and serialization logic.

What to change

  • Have exportData save subscriptions first and filters then. The current parsing code doesn't care due to our filter caching policy (a.k.a. memory leak), with Emscripten we will save an unnecessary reference to the filters when parsing.
  • Stop parsing [User patterns], [Pattern] and [Subscription patterns] sections, we stopped writing those a long time ago (around Adblock Plus 0.7).
  • Remove special treatment of ~fl~ and similar groups (again, this is compatibility with Adblock Plus 0.7 era).
  • Remove silent parameter from FilterStorage.addFilter(), FilterStorage.addSubscription() and FilterStorage.removeSubscription() - only the former was still being used, and the last usage of that parameter is being removed now.
  • Bump formatVersion property.

Attachments (0)

Change History (5)

comment:1 Changed on 04/18/2017 at 01:20:47 PM by trev

  • Description modified (diff)

comment:2 Changed on 04/18/2017 at 01:25:43 PM by trev

  • Description modified (diff)

comment:3 Changed on 04/18/2017 at 01:34:33 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/20/2017 at 08:19:12 AM by abpbot

A commit referencing this issue has landed:
Issue 5153 - Simplify patterns.ini parsing

comment:5 Changed on 04/20/2017 at 08:19:54 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.