Opened 7 months ago

Closed 2 days ago

#5159 closed change (fixed)

[emscripten] Expose BlockingFilter.collapse property

Reported by: trev Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29574665/

Description

Background

In #4125 we implemented parsing for $~collapse option but didn't expose it. Given that we no longer support a global off-switch for collapsing, $collapse is the default behavior and can be ignored.

What to change

Turn RegExpFilter.mCollapse into a boolean defaulting to true and expose it on BlockingFilter.

Change History (4)

comment:1 Changed 6 weeks ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 6 weeks ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 days ago by abpbot

A commit referencing this issue has landed:
Issue 5159 - Expose collapse property for BlockingFilter

comment:4 Changed 2 days ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.