Opened 3 years ago

Closed 2 years ago

#5160 closed change (fixed)

[emscripten] Expose changed class and property names to JavaScript

Reported by: trev Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29573895/

Description

Background

In #4127 we renamed SpecialSubscription into UserDefinedSubscription. Also, some DownloadableSubscription properties were renamed: expires into hardExpiration, errors into errorCount, version into dataRevision. These changes are limited to the C++ code so far, JS bindings expose the old names.

What to change

Expose the new names via JS bindings. Change lib/subscriptionClasses.js to establish the old names as aliases for the new names. This aliasing should be removed eventually.

Change History (4)

comment:1 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 2 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5160 - Alias new class names and properties.

comment:4 Changed 2 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.