Changes between Version 3 and Version 4 of Ticket #5161


Ignore:
Timestamp:
05/04/2017 02:52:17 PM (3 years ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5161

    • Property Summary changed from Use maps, sets, and null-prototype objects where appropriate to Use maps and sets where appropriate
  • Ticket #5161 – Description

    v3 v4  
    55 
    66=== What to change === 
    7 In general, go through the code looking for instances where plain objects could be replaced with maps, sets, or just plain objects with a null prototype as appropriate. 
     7In general, go through the code looking for instances where plain objects could be replaced with maps or sets as appropriate. 
    88 
    99In particular the following changes could be made: 
     
    1414  * `framesOfTabs` could be a map 
    1515  * Values of `framesOfTabs` could also be maps 
    16   * "Frame" objects could have their prototype set to null 
    1716  * If `nonEmptyPageMaps` is a set, avoid unnecessarily adding to or deleting from the set 
    18   * If `this._map` in `ext.PageMap` is a map, avoid creating an intermediate array inside `ext.PageMap.prototype.keys` by implementing a generic utility function for mapping an iterable 
     17  * If `this._map` in `ext.PageMap` is a map, avoid creating an intermediate array inside `ext.PageMap.prototype.keys`, instead return the iterable 
    1918 * In `lib/devtools.js`: 
    2019  * `panels` could be a map 
    2120 * In `lib/popupBlocker.js`: 
    2221  * `loadingPopups` could be a map 
    23   * "Popup" objects could have their prototype set to null 
    2422 * In `lib/whitelisting.js`: 
    2523  * Values of `sitekeys` could be maps