Opened 3 years ago

Closed 3 years ago

#5163 closed change (fixed)

Reduce the use of FilterPtr

Reported by: hfiguiere Assignee: hfiguiere
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29419607

Description

Background

Reduce the use of FilterPtr

What to change

  • Change FilterPtr to be a unique_ptr<>
  • Pass a Filter& whenever it is appropriate (mostly everywhere but FilterEngine::Matches related methods).

Change History (4)

comment:1 Changed 3 years ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5163 - Reduce the use of FilterPtr

comment:4 Changed 3 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.