Opened 2 years ago

Closed 2 years ago

#5167 closed change (fixed)

Update to use libadblockplus revision dca8df9af1a7

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By:
Blocking: #5205 Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29421687/
https://codereview.adblockplus.org/29429555/

Description

Background

There were some significant changes in API (method signatures) so libadblockplus-android should be updated.

What to change

Native glue classes should use new API.

Change History (10)

comment:1 Changed 2 years ago by asmirnov

After code review with Sergey we've found some changes should be done in libadblockplus, so updating to 2b0c6fd016be is required now

comment:2 Changed 2 years ago by asmirnov

  • Summary changed from Update to use libadblockplus rev. 91a56535914c to Update to use libadblockplus rev. 2b0c6fd016be

comment:3 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:4 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:5 Changed 2 years ago by asmirnov

  • Summary changed from Update to use libadblockplus rev. 2b0c6fd016be to Update to use libadblockplus revision 2b0c6fd016be

comment:6 Changed 2 years ago by asmirnov

  • Blocking 5205 added

comment:7 Changed 2 years ago by asmirnov

  • Summary changed from Update to use libadblockplus revision 2b0c6fd016be to Update to use libadblockplus revision dca8df9af1a7

comment:8 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:9 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

comment:10 Changed 2 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.