Opened 2 years ago

Closed 2 years ago

#5169 closed change (fixed)

Implement "Whitelisted Websites" tab for new options page

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: wspee, greiner Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29411555/

Description (last modified by saroyanm)

Background

After several design iterations we finally have a final version of the new options page (See #5158).

What to change

Implement "Whitelisted Websites" tab as specified in the ​Options Page Specification.

Change History (9)

comment:1 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:2 Changed 2 years ago by saroyanm

@Winsley please let me know if the links to specs looks fine to you.
@Thomas please make the issue ready as soon you think it is.

comment:3 follow-up: Changed 2 years ago by saroyanm

  • Description modified (diff)

Updated link to reflect final revision, not master. @Winsley let me know if you think this should be reverted.

comment:4 Changed 2 years ago by greiner

  • Component changed from Unknown to User-Interface
  • Priority changed from Unknown to P2
  • Ready set

comment:5 in reply to: ↑ 3 Changed 2 years ago by wspee

Replying to saroyanm:

Updated link to reflect final revision, not master. @Winsley let me know if you think this should be reverted.

Link's to the specification should always be to a specific version so they don't change auto magically. Your link also links to the correct section, so IMHO it's fine.

comment:6 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:7 Changed 2 years ago by abpbot

comment:8 Changed 2 years ago by saroyanm

For styles implementation I think make sense to create separate issue, while most of them will be global and apply to different issues as well.

comment:9 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

See comment above

Note: See TracTickets for help on using tickets.