Opened 5 years ago

Closed 5 years ago

#517 closed change (fixed)

[Typed objects] Make unit tests compatible with Chrome and Safari

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By: #427, #516
Blocking: #145 Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5090313282519040/

Description

Background

The typed objects code files are using syntax that is currently only supported by Firefox. Consequently, the unit tests fail in Chrome.

What to change

Automatically run JSHydra when the unit tests run in a browser not supporting JavaScript 1.7 in order to convert the Firefox-specific syntax.

Change History (3)

comment:1 Changed 5 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 years ago by philll

  • Platform set to Firefox

comment:3 Changed 5 years ago by trev

  • Platform changed from Firefox to Chrome
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.