Opened 3 years ago

Closed 2 years ago

#5170 closed change (fixed)

Force usage of Android version code v0 function

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: fhd Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29420569/

Description (last modified by diegocarloslima)

Background

While we published Adblock Browser 1.1.1, Mozilla has introduced a new function for generating the Android version code, namely android_version_code_v1. But since we published our app using the v0 function, our version code currently starts with 2016XXXXXX, which is greater than the version codes generated by the v1 function, which starts with 2015XXXXXX.

What to change

We need to force the usage of android_version_code_v0 in android_version_code.py, so we can still generate incremental versionCodes.

Hints for Testers

There are a few ways to verify the versionCode:

1) run aapt dump badging apkname.apk . It will print something like versionCode='2017061227'. The aapt tool is located in the build-tools sub-folder of the Android SDK

2) Use apktool d apkname.apk . The apk will be extracted to a folder that contains a file calledapktool.yml, which will have something like versionCode: '2017061227'. This tool can be downloaded here

3) Build the project and look for the android:versionCode in the generated objdir-droid/mobile/android/base/generated/preprocessed/org/mozilla/gecko/AndroidManifest.xml file

Change History (10)

comment:1 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5170 - Force usage of Android version code v0 function

comment:3 Changed 3 years ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened

For help with me understanding how this should then show on the build, should the new build naming of adblockbrowser-1.1.1.20170612182010-arm mean that this is now the correct version code? If not, is there some other way for me to check this?

comment:5 Changed 2 years ago by diegocarloslima

Actually, the versionCode (2017061227) is different from the BuildId (20170612182010). I will update the description with the hints for testers

Last edited 2 years ago by diegocarloslima (previous) (diff)

comment:6 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:7 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:8 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:9 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:10 Changed 2 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Tester changed from Unknown to Scheer
  • Verified working set
  • aapt dump badging apkname.apk shows version code as versionCode='20170612182010'.

adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.