Opened on 04/21/2017 at 12:40:26 PM

Closed on 07/05/2017 at 08:24:50 AM

#5170 closed change (fixed)

Force usage of Android version code v0 function

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: fhd Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by diegocarloslima)


While we published Adblock Browser 1.1.1, Mozilla has introduced a new function for generating the Android version code, namely android_version_code_v1. But since we published our app using the v0 function, our version code currently starts with 2016XXXXXX, which is greater than the version codes generated by the v1 function, which starts with 2015XXXXXX.

What to change

We need to force the usage of android_version_code_v0 in, so we can still generate incremental versionCodes.

Hints for Testers

There are a few ways to verify the versionCode:

1) run aapt dump badging apkname.apk . It will print something like versionCode='2017061227'. The aapt tool is located in the build-tools sub-folder of the Android SDK

2) Use apktool d apkname.apk . The apk will be extracted to a folder that contains a file calledapktool.yml, which will have something like versionCode: '2017061227'. This tool can be downloaded here

3) Build the project and look for the android:versionCode in the generated objdir-droid/mobile/android/base/generated/preprocessed/org/mozilla/gecko/AndroidManifest.xml file

Attachments (0)

Change History (10)

comment:1 Changed on 04/24/2017 at 09:56:57 AM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/24/2017 at 11:15:37 AM by abpbot

A commit referencing this issue has landed:
Issue 5170 - Force usage of Android version code v0 function

comment:3 Changed on 04/24/2017 at 11:16:02 AM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 06/21/2017 at 08:25:47 AM by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened

For help with me understanding how this should then show on the build, should the new build naming of adblockbrowser- mean that this is now the correct version code? If not, is there some other way for me to check this?

comment:5 Changed on 06/30/2017 at 06:45:57 PM by diegocarloslima

Actually, the versionCode (2017061227) is different from the BuildId (20170612182010). I will update the description with the hints for testers

Last edited on 06/30/2017 at 06:58:56 PM by diegocarloslima

comment:6 Changed on 06/30/2017 at 07:14:48 PM by diegocarloslima

  • Description modified (diff)

comment:7 Changed on 06/30/2017 at 07:16:55 PM by diegocarloslima

  • Description modified (diff)

comment:8 Changed on 06/30/2017 at 07:19:21 PM by diegocarloslima

  • Description modified (diff)

comment:9 Changed on 07/04/2017 at 08:19:52 PM by diegocarloslima

  • Description modified (diff)

comment:10 Changed on 07/05/2017 at 08:24:50 AM by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Tester changed from Unknown to Scheer
  • Verified working set
  • aapt dump badging apkname.apk shows version code as versionCode='20170612182010'.

Galaxy S7
Android 7.0

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Note: See TracTickets for help on using tickets.