Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5173 closed defect (fixed)

ABP Samsung Internet fails to initialise on Android 5.0.1

Reported by: scheer Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu, diegocarloslima Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29422622/

Description

When trying to launch ABP for Samsung Internet, the app loads, but fails to initialise and then crashes to the home screen.

This issue is not experienced on Android 7.0 (Galaxy S7)

Environment

adblockplussbrowser-1.1.0-signed-zipaligned
Galaxy S4
Android 5.0.1

How to reproduce

  1. Launch ABP Samsung Internet

Observed behaviour

The app attempts to initialise, but crashes to home screen.

Expected behaviour

The app initialises correctly.

Attachments (1)

Galaxy S4 Android 5.0.1 Sbrowser 1.1.0.txt (76.5 KB) - added by scheer 3 years ago.

Download all attachments as: .zip

Change History (9)

Changed 3 years ago by scheer

comment:1 Changed 3 years ago by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Owner set to diegocarloslima
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 3 years ago by diegocarloslima

This issue was due an inconsistency in UrlInputOpenerPreference.setIcon() which would result in a StackOverflowError on devices running Android 5.

comment:3 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by scheer

  • Verified working set
  • The app now correctly initialises on Android 5.0.

adblockplussbrowser-1.1.0-testfix-signed-zipaligned
Galaxy S4
Android 5.0.1

comment:5 Changed 3 years ago by abpbot

comment:6 Changed 3 years ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 3 years ago by diegocarloslima

  • Milestone Adblock-Plus-for-Samsung-Browser-next deleted

This was released on 1.1.0

comment:8 Changed 3 years ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0
Note: See TracTickets for help on using tickets.