Opened 7 months ago

Last modified 2 days ago

#5175 reviewing change

[emscripten] Reject element hiding filters with effectively empty domain names

Reported by: trev Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29600641/

Description

Background

We implemented #4450 on master branch but not in Emscripten.

What to change

Parsing should reject element hiding filters with a non-empty domain part that is equivalent to an empty domain. See #4450 for example of such filters. Parsing result should be an InvalidFilter with reason set to filter_invalid_domain. Also, we should add testEmptyElemHideDomains from master branch - it should pass with merely filter.delete() being added.

Change History (2)

comment:1 Changed 3 weeks ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 2 days ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.