Opened 3 years ago

Closed 3 months ago

#5175 closed change (rejected)

[emscripten] Reject element hiding filters with effectively empty domain names

Reported by: trev Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29600641/
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/5

Description

Background

We implemented #4450 on master branch but not in Emscripten.

What to change

Parsing should reject element hiding filters with a non-empty domain part that is equivalent to an empty domain. See #4450 for example of such filters. Parsing result should be an InvalidFilter with reason set to filter_invalid_domain. Also, we should add testEmptyElemHideDomains from master branch - it should pass with merely filter.delete() being added.

Change History (4)

comment:1 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 2 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 12 months ago by hfiguiere

  • Review URL(s) modified (diff)

comment:4 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.