Opened on 04/25/2017 at 10:35:55 AM

Last modified on 10/08/2019 at 05:52:25 PM

#5182 new change

Fix IsConnectionAllowed

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd Blocked By: #5066
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)


IsConnectionAllowed had been implemented in a hurry and we had cut some corners, now it's time to fix it.

What to change

Remove it from implementation of XMLHttpRequest in compat.js
However it will be possible only after implementing it in adblockpluscore as #5066.

Attachments (0)

Change History (9)

comment:1 Changed on 04/28/2017 at 10:45:06 AM by sergz

  • Blocked By 5198 added

I have removed it from JsEngine and from WebRequestThread and made the execution of it asynchronous in FilterEngine, though it is still in a detached thread (added blocked by #5198).

The codereview will be after landing of, because otherwise tests don't work anymore, and after because it uses that code.

Last edited on 04/28/2017 at 02:48:41 PM by sergz

comment:2 Changed on 04/28/2017 at 02:48:23 PM by sergz

  • Review URL(s) modified (diff)

comment:3 Changed on 05/02/2017 at 01:20:26 PM by abpbot

A commit referencing this issue has landed:
Issue 5182 - fix IsConnectionAllowed

comment:4 Changed on 05/02/2017 at 01:29:19 PM by sergz

  • Blocking 5180 removed
  • Description modified (diff)

The landed patch allows to work on #5180 in parallel, so the issue is not blocking #5180 now.

comment:5 Changed on 05/10/2017 at 04:00:40 PM by sergz

  • Owner set to sergz

I am working on the part related to #4688, namely removing of LazyWebRequest. It will also cause the change to make IsConnectionAllowed asynchronous. Meanwhile it will be also renamed because the same line will be changed anyway as a part this work.

comment:6 Changed on 05/11/2017 at 09:38:29 AM by sergz

  • Review URL(s) modified (diff)

comment:7 Changed on 05/11/2017 at 09:49:35 AM by abpbot

comment:8 Changed on 05/11/2017 at 10:09:55 AM by sergz

  • Blocked By 5179, 5198 removed
  • Blocking 3595 removed
  • Description modified (diff)
  • Owner sergz deleted
  • Summary changed from Fix IsAllowedConnection to Fix IsConnectionAllowed

Remove from the issue already landed parts.

comment:9 Changed on 09/27/2019 at 06:44:29 AM by nps1337


Last edited on 10/08/2019 at 05:52:25 PM by kzar

Add Comment

Modify Ticket

Change Properties
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Note: See TracTickets for help on using tickets.