Changes between Version 6 and Version 8 of Ticket #5182


Ignore:
Timestamp:
05/11/2017 10:09:55 AM (22 months ago)
Author:
sergz
Comment:

Remove from the issue already landed parts.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5182

    • Property Blocked By changed from 5066, 5179, 5198 to 5066
    • Property Summary changed from Fix IsAllowedConnection to Fix IsConnectionAllowed
    • Property Owner sergz deleted
    • Property Blocking changed from 3595 to
  • Ticket #5182 – Description

    v6 v8  
    11=== Background === 
    2 `IsAllowedConnection` had been implemented in a hurry and we had cut some corners, now it's time to fix it, especially because it affects a threading model. 
     2`IsConnectionAllowed` had been implemented in a hurry and we had cut some corners, now it's time to fix it. 
    33 
    44=== What to change === 
    5 The issue is pretty comprehensive 
    6 - rename it\\This method is applicable only for subscriptions download, so it should not be called in a so generic manner. 
    7 - remove it from implementation of `XMLHttpRequest` in `compat.js`\\However it will be possible only after implementing it in ''adblockpluscore'' as #5066. 
    8 - make it asynchronous\\In order to avoid blocking of execution of JS code (see above, it's called from JS and not from a worker thread) the asynchronicity should be either implemented in FilterEngine or supported by a provider of the callback, in the latter case the callback should be async. It seems so far, in order to simplify the life of users of libadblockplus it would be better to have it in FilterEngine.\\Until asynchronous executor is not ready one may just run it a detached thread. 
     5Remove it from implementation of `XMLHttpRequest` in `compat.js`\\However it will be possible only after implementing it in ''adblockpluscore'' as #5066. 
    96 
    10