Opened 3 years ago

Closed 3 years ago

#5189 closed change (fixed)

Optimize the code by using of r-value references

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: hub Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29422625/

Description

Background

In the context of recent changes (#5034, #5163, #5164, #5165 and others) while reviewing the changes for android it turned out that we can optimize the performance by proper support of move semantics when it's possible.

What to change

Pass objects (JsValueList, JsValue ,Filter, Notification) which are not supposed to be used anymore by r-value reference.

Change History (3)

comment:1 Changed 3 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

comment:3 Changed 3 years ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

I'm closing this issue, however it maybe reopened and a codereview can be added if there is still something like this.

Note: See TracTickets for help on using tickets.