Opened 8 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#5192 closed change (fixed)

Add notification for users without Samsung Internet

Reported by: mario Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: diegocarloslima Blocked By:
Blocking: Platform: Samsung Browser
Ready: no Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29430593/

Description (last modified by diegocarloslima)

Background

This change is an extension of #3846.
As Samsung Internet will be available to users without Samsung devices, we want to extend the supported devices as well. However it is then possible to download ABP for Samsung Internet without having Samsung Internet actually installed. Thus we need to check for the presence of Samsung Internet and display a notification if it is not installed on the users device.

#3846 stays intact.

What to change

UI
Implement a standard Android notification with the following content:
Headline: You need Samsung Internet
Body: Before you can use Adblock Plus, you must install Samsung Internet 4.0 or above.
Button: Install now

Controls
If the button of the notification is clicked, open the Play Store and display the page for Samsung Internet.

Logic
The notification is shown on every ABP startup if all of the following requirements are met:

  • The user runs any Android version above Android 5 (Lollipop)
  • The user lacks any version of Samsung Internet or the current installed version is below 4.0

The notification is not closable.

Note: These changes should also apply for all currently supported languages.

Change History (8)

comment:1 Changed 7 weeks ago by diegocarloslima

  • Description modified (diff)

comment:2 Changed 7 weeks ago by diegocarloslima

  • Description modified (diff)
  • Summary changed from Add notification for users without SBrowser to Add notification for users without Samsung Internet

comment:3 Changed 6 weeks ago by diegocarloslima

  • Cc diegocarloslima added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 6 weeks ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The following text is correctly shown when the user starts up ABP for Samsung Internet and Samsung Internet 5.0+ is not installed:
Headline: You need Samsung Internet
Body: Before you can use Adblock Plus, you must install Samsung Internet 4.0 or above.
Button: Install now
  • If the user selects the 'Install now' button, they are correctly navigated to Samsung Internet in the play store. One thing to note here is that currently, the release version of Samsung Internet is not 5.0 (the version that supports Nexus and other device support). So, although I was able to verify that selecting the install button takes the user to the Samsung Internet Play Store page, I could not confirm that installing the app from that link does (I had to then search for the beta to try out). But, I don't overly see any issues here.
  • The notification is not closable.
  • An additional note here would be that Test object does not allow for installation of ABP for Samsung on Android 4.9 and under, so the message would technically not be able to be tested on anything below Android 5.0.'

adblockplussbrowser-release-signed-1
LG Nexus 4 E960
Android 5.1.1
(Samsung Internet Beta 5.4.00-70)

adblockplussbrowser-release-signed-1
LG Nexus 5
Android 6.0.1
(Samsung Internet Beta 5.4.00-70)

adblockplussbrowser-release-signed-1
Huawei Nexus 6P
Android 7.1.1
(Samsung Internet Beta 5.4.00-70)

comment:5 Changed 6 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 5192 - Add notification for users without Samsung Internet

comment:6 Changed 6 weeks ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 6 weeks ago by jwangenheim

  • Milestone changed from Adblock-Plus-for-Samsung-Browser-next to Adblock-Plus-for-Samsung-Browser-1.1.0

comment:8 Changed 6 weeks ago by jwangenheim

  • Owner set to jwangenheim
Note: See TracTickets for help on using tickets.