Opened 2 years ago

Last modified 2 years ago

#5192 closed change

Add notification for users without Samsung Internet — at Version 3

Reported by: mario Assignee:
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: diegocarloslima Blocked By:
Blocking: Platform: Samsung Browser
Ready: no Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29430593/

Description (last modified by diegocarloslima)

Background

This change is an extension of #3846.
As Samsung Internet will be available to users without Samsung devices, we want to extend the supported devices as well. However it is then possible to download ABP for Samsung Internet without having Samsung Internet actually installed. Thus we need to check for the presence of Samsung Internet and display a notification if it is not installed on the users device.

#3846 stays intact.

What to change

UI
Implement a standard Android notification with the following content:
Headline: You need Samsung Internet
Body: Before you can use Adblock Plus, you must install Samsung Internet 4.0 or above.
Button: Install now

Controls
If the button of the notification is clicked, open the Play Store and display the page for Samsung Internet.

Logic
The notification is shown on every ABP startup if all of the following requirements are met:

  • The user runs any Android version above Android 5 (Lollipop)
  • The user lacks any version of Samsung Internet or the current installed version is below 4.0

The notification is not closable.

Note: These changes should also apply for all currently supported languages.

Change History (3)

comment:1 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:2 Changed 2 years ago by diegocarloslima

  • Description modified (diff)
  • Summary changed from Add notification for users without SBrowser to Add notification for users without Samsung Internet

comment:3 Changed 2 years ago by diegocarloslima

  • Cc diegocarloslima added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.