Opened 22 months ago

Last modified 22 months ago

#5197 new change

Add FilterEngine::SetSubscriptionrChangeCallback

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov Blocked By: #5123, #5123, #5196
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Currently we receive all kind of notifications in FilterEngine::SetFilterChangeCallback as event (e.g. subscription.disabled) and JsValue&& object, however the user of libadblockplus for the above example should rather receive ("disabled", Subscription&&). Therefore we need to differentiate events from different sources, namely filter, subscription and others and pass a concrete object (Filter&& for filter and Subscription&& for subscription) instead of JsValue. So, since the signature for FilterEngine::SetFilterChangeCallback will be also changed it will force the users to adapt the code (if not now then later after not exposing JsValue from Filter), meanwhile to still provide them with the ability to get other events we need to add some way like FilterEngine::SetGenericEventCallback.

Change History (7)

comment:1 Changed 22 months ago by sergz

  • Blocking 5123, 5196 added

comment:2 Changed 22 months ago by sergz

  • Blocked By 5123, 5196 added
  • Blocking 5123, 5196 removed

comment:3 Changed 22 months ago by sergz

  • Blocked By 5123, 5196 removed

comment:4 Changed 22 months ago by sergz

  • Blocked By 5123, 5196 added

comment:5 Changed 22 months ago by sergz

  • Blocked By 5123, 5196 removed

comment:6 Changed 22 months ago by sergz

  • Blocked By 5123, 5196 added

comment:7 Changed 22 months ago by abpbot

  • Blocked By
Note: See TracTickets for help on using tickets.