Opened 6 years ago

Closed 3 months ago

#52 closed change (rejected)

Refactor filter/subscription change notifications

Reported by: trev Assignee:
Priority: P5 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Blocked By:
Blocking: Platform:
Ready: Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Currently the filter and subscription properties triggering notifications are a getter/setter combination, the setter will call FilterNotifier. This is ugly and adds an otherwise pointless dependency on FilterNotifier in filterClasses and subscriptionClasses.

What to change

The proposal is to have these properties as regular properties. When FilterNotifier starts up it should load filterClasses and subscriptionClasses and replace the properties by a getter/setter combination that will trigger notifications.

Change History (3)

comment:1 Changed 6 years ago by trev

  • Component changed from Unknown to Core
  • Priority changed from Unknown to P5

This issue will likely be superseded by our current typed objects/ChimeraScript work.

comment:2 Changed 6 years ago by trev

  • Reporter changed from philll to trev

comment:3 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.