Opened 3 years ago

Closed 3 years ago

#5208 closed change (fixed)

Adding new hires and fix typos on eyeo.com/team/

Reported by: jsitarz Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: erick, saroyanm, jsitarz, maren, wspee, juliandoucette, lisabielik Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29434565/

Description (last modified by juliandoucette)

New Hires

Name

Ire Aderinokun

date

2017-05-02 

Position title

Developer

flag

ng

about

Developer, designer, and advocate for the open web

Name

Jens Wangenheim

date

2017-05-02 

Position title

Developer

flag

de

about

Problem solver and food waste fighter, with much love for nature, sports and cuisine

Name

Jan Oczenasek

date

2017-05-02 

Position title

Student Help (Public Affairs)

flag

de

about

International Relations student fascinated by politics and communication. Loves to swim, go bouldering, read graphic novels and advocate Linux.

Name

Linus Olsson

date

2017-03-22

Position title

Project Manager (Flattr)

flag

se

about

Has something to say about everything, apparently

Typos to Fix

Listed in Code Review Message #5

Attachments (4)

Jens pic.jpg (32.0 KB) - added by jsitarz 3 years ago.
Ire pic.jpg (34.3 KB) - added by jsitarz 3 years ago.
jan.jpg (13.7 KB) - added by jsitarz 3 years ago.
Linus.jpg (17.7 KB) - added by jsitarz 3 years ago.

Download all attachments as: .zip

Change History (27)

Changed 3 years ago by jsitarz

Changed 3 years ago by jsitarz

comment:1 Changed 3 years ago by jsitarz

  • Description modified (diff)

comment:2 Changed 3 years ago by jsitarz

@Maren, could you please add Jan's nationality?

comment:3 Changed 3 years ago by ire

  • Owner set to iaderinokun

comment:4 follow-up: Changed 3 years ago by wspee

@jsitarz
The image for Jan is missing

comment:5 Changed 3 years ago by jsitarz

  • Description modified (diff)

comment:6 in reply to: ↑ 4 Changed 3 years ago by jsitarz

Replying to wspee:

@jsitarz
The image for Jan is missing

Jan sent us his private pic and asked Peter to adjust it to our website standards

Changed 3 years ago by jsitarz

comment:7 Changed 3 years ago by wspee

  • Cc juliandoucette added
  • Keywords goodfirstbug added
  • Priority changed from Unknown to P3

comment:8 Changed 3 years ago by wspee

  • Ready set

comment:9 Changed 3 years ago by ire

@jsitarz

Question regarding the titles. Usually the position is just "Developer", but in this case it is specified "Web Developer" and "Android Developer". Am I to make this distinction on the team page, or just have both as "Developer"?

Last edited 3 years ago by ire (previous) (diff)

comment:10 Changed 3 years ago by jsitarz

@iaderinokun let's go for just developer

comment:11 Changed 3 years ago by ire

  • Status changed from new to reviewing

comment:12 Changed 3 years ago by jsitarz

  • Description modified (diff)

Changed 3 years ago by jsitarz

comment:13 Changed 3 years ago by ire

@jsitarz

Is there a typo on Linus's description? Should it be "Has something to say about everything, apparently.", so "Has" instead of "Have".

Could we have a content developer review everything here?

comment:14 Changed 3 years ago by ire

  • Cc lisabielik added

comment:15 Changed 3 years ago by wspee

@iaderinokun
The about sentences are written by the employees themselves. To avoid surprises perhaps it's best to ask Linus directly about it?

comment:16 Changed 3 years ago by ire

  • Description modified (diff)

I have asked Linus and he said my correction was correct. So I'll update the ticket.

comment:17 Changed 3 years ago by wspee

  • Review URL(s) modified (diff)

comment:18 Changed 3 years ago by ire

  • Description modified (diff)
  • Summary changed from Adding new hires to eyeo.com/team/ to Adding new hires and fix typos on eyeo.com/team/

comment:19 follow-up: Changed 3 years ago by juliandoucette

  • Description modified (diff)

You were there twice Ire ;)

comment:20 Changed 3 years ago by juliandoucette

  • Description modified (diff)

Updated fields based on Lisa's feedback.

Last edited 3 years ago by juliandoucette (previous) (diff)

comment:21 in reply to: ↑ 19 Changed 3 years ago by ire

Replying to juliandoucette:

You were there twice Ire ;)

Ah thanks :)

comment:22 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5208 - Adding new hires and fix typos on eyeo.com/team/

comment:23 Changed 3 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.