Opened on 05/04/2017 at 12:40:10 PM

Closed on 05/16/2017 at 06:43:01 PM

#5208 closed change (fixed)

Adding new hires and fix typos on eyeo.com/team/

Reported by: jsitarz Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: erick, saroyanm, jsitarz, maren, wspee, juliandoucette, lisabielik Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29434565/

Description (last modified by juliandoucette)

New Hires

Name

Ire Aderinokun

date

2017-05-02 

Position title

Developer

flag

ng

about

Developer, designer, and advocate for the open web

Name

Jens Wangenheim

date

2017-05-02 

Position title

Developer

flag

de

about

Problem solver and food waste fighter, with much love for nature, sports and cuisine

Name

Jan Oczenasek

date

2017-05-02 

Position title

Student Help (Public Affairs)

flag

de

about

International Relations student fascinated by politics and communication. Loves to swim, go bouldering, read graphic novels and advocate Linux.

Name

Linus Olsson

date

2017-03-22

Position title

Project Manager (Flattr)

flag

se

about

Has something to say about everything, apparently

Typos to Fix

Listed in Code Review Message #5

Attachments (4)

Jens pic.jpg (32.0 KB) - added by jsitarz on 05/04/2017 at 12:40:19 PM.
Ire pic.jpg (34.3 KB) - added by jsitarz on 05/04/2017 at 12:40:27 PM.
jan.jpg (13.7 KB) - added by jsitarz on 05/08/2017 at 01:57:19 PM.
Linus.jpg (17.7 KB) - added by jsitarz on 05/09/2017 at 12:22:19 PM.

Download all attachments as: .zip

Change History (27)

Changed on 05/04/2017 at 12:40:19 PM by jsitarz

Changed on 05/04/2017 at 12:40:27 PM by jsitarz

comment:1 Changed on 05/04/2017 at 02:23:41 PM by jsitarz

  • Description modified (diff)

comment:2 Changed on 05/04/2017 at 02:24:10 PM by jsitarz

@Maren, could you please add Jan's nationality?

comment:3 Changed on 05/04/2017 at 04:54:35 PM by ire

  • Owner set to iaderinokun

comment:4 follow-up: Changed on 05/05/2017 at 09:35:57 AM by wspee

@jsitarz
The image for Jan is missing

comment:5 Changed on 05/05/2017 at 12:53:24 PM by jsitarz

  • Description modified (diff)

comment:6 in reply to: ↑ 4 Changed on 05/05/2017 at 12:55:00 PM by jsitarz

Replying to wspee:

@jsitarz
The image for Jan is missing

Jan sent us his private pic and asked Peter to adjust it to our website standards

Changed on 05/08/2017 at 01:57:19 PM by jsitarz

comment:7 Changed on 05/09/2017 at 10:04:52 AM by wspee

  • Cc juliandoucette added
  • Keywords goodfirstbug added
  • Priority changed from Unknown to P3

comment:8 Changed on 05/09/2017 at 10:05:27 AM by wspee

  • Ready set

comment:9 Changed on 05/09/2017 at 10:44:51 AM by ire

@jsitarz

Question regarding the titles. Usually the position is just "Developer", but in this case it is specified "Web Developer" and "Android Developer". Am I to make this distinction on the team page, or just have both as "Developer"?

Last edited on 05/09/2017 at 10:52:28 AM by ire

comment:10 Changed on 05/09/2017 at 12:02:47 PM by jsitarz

@iaderinokun let's go for just developer

comment:11 Changed on 05/09/2017 at 12:12:37 PM by ire

  • Status changed from new to reviewing

comment:12 Changed on 05/09/2017 at 12:20:47 PM by jsitarz

  • Description modified (diff)

Changed on 05/09/2017 at 12:22:19 PM by jsitarz

comment:13 Changed on 05/09/2017 at 12:43:30 PM by ire

@jsitarz

Is there a typo on Linus's description? Should it be "Has something to say about everything, apparently.", so "Has" instead of "Have".

Could we have a content developer review everything here?

comment:14 Changed on 05/09/2017 at 12:54:06 PM by ire

  • Cc lisabielik added

comment:15 Changed on 05/10/2017 at 07:13:18 AM by wspee

@iaderinokun
The about sentences are written by the employees themselves. To avoid surprises perhaps it's best to ask Linus directly about it?

comment:16 Changed on 05/10/2017 at 08:10:48 AM by ire

  • Description modified (diff)

I have asked Linus and he said my correction was correct. So I'll update the ticket.

comment:17 Changed on 05/12/2017 at 01:58:35 PM by wspee

  • Review URL(s) modified (diff)

comment:18 Changed on 05/16/2017 at 02:02:51 PM by ire

  • Description modified (diff)
  • Summary changed from Adding new hires to eyeo.com/team/ to Adding new hires and fix typos on eyeo.com/team/

comment:19 follow-up: Changed on 05/16/2017 at 03:14:36 PM by juliandoucette

  • Description modified (diff)

You were there twice Ire ;)

comment:20 Changed on 05/16/2017 at 03:22:22 PM by juliandoucette

  • Description modified (diff)

Updated fields based on Lisa's feedback.

Last edited on 05/16/2017 at 03:22:59 PM by juliandoucette

comment:21 in reply to: ↑ 19 Changed on 05/16/2017 at 06:27:36 PM by ire

Replying to juliandoucette:

You were there twice Ire ;)

Ah thanks :)

comment:22 Changed on 05/16/2017 at 06:40:45 PM by abpbot

A commit referencing this issue has landed:
Issue 5208 - Adding new hires and fix typos on eyeo.com/team/

comment:23 Changed on 05/16/2017 at 06:43:01 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.