Opened 3 years ago

Closed 3 years ago

#5212 closed change (fixed)

IRC hook should report bookmarked branches

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29430555/

Description

Background

Our Mercurial hook sending commit messages to IRC reports the branch that the commit happened on. It only reports Mercurial branches however - this is not too useful given that we mainly use bookmarked branches.

What to change

Send bookmarks for the branch to the IRC bot. Only use the Mercurial branch as fallback or if it isn't the default branch.

Change History (4)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5212 - IRC hook should report bookmarked branches

comment:4 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.