Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5215 closed change (fixed)

[ABP for Samsung Internet] - Inconsistent string needs updating

Reported by: Shikitita Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: diegocarloslima, lisabielik, vickyyu, mario Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29435610/

Description

Background

A string currently used for ABP for Samsung Internet needs changing due to consistency reasons

What to change

"Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the Allow some nonintrusive ads option."

should be changed to

"Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the Allow some nonintrusive advertising option."

Attachments (3)

ABP_SBrowser_Whitelist_00.png (40.0 KB) - added by mario 2 years ago.
ABP_SBrowser_Whitelist_01.png (47.9 KB) - added by mario 2 years ago.
ABP_SBrowser_Whitelist_02.png (124.0 KB) - added by mario 2 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 2 years ago by diegocarloslima

  • Owner diegocarloslima deleted
  • Ready set

comment:2 follow-up: Changed 2 years ago by scheer

  • In addition to the above, 'Acceptable Ads' is still displayed as a title in the main settings screen of ABP. Although the select box name is correctly displayed as 'Allow some nonintrusive advertising', the title is 'Acceptable Ads'. I guess, for consistency, this needs to also be changed?

Changed 2 years ago by mario

Changed 2 years ago by mario

Changed 2 years ago by mario

comment:3 Changed 2 years ago by jwangenheim

  • Owner set to jwangenheim

comment:4 Changed 2 years ago by mario

I accidentally added three screenshots to the wrong ticket. Please ignore until removed.

comment:5 Changed 2 years ago by jwangenheim

  • Blocked By 5193 added

comment:6 in reply to: ↑ 2 Changed 2 years ago by Shikitita

Replying to scheer:

  • In addition to the above, 'Acceptable Ads' is still displayed as a title in the main settings screen of ABP. Although the select box name is correctly displayed as 'Allow some nonintrusive advertising', the title is 'Acceptable Ads'. I guess, for consistency, this needs to also be changed?

Not necessarily. ABB and ABP for iOS have a section named "Acceptable Ads" which, after tapping on it, displays the option "Allow some nonintrusive advertising", that you can then enable or disable, and also an explanation of what Acceptable Ads is/means. Most of our users should know, by now, about our "Acceptable Ads" initiative, therefore having it as a title makes sense and also keeps consistency across most of our products.

comment:7 Changed 2 years ago by jwangenheim

  • Blocked By 5193 removed

comment:8 Changed 2 years ago by jwangenheim

  • Status changed from new to reviewing

comment:9 Changed 2 years ago by jwangenheim

  • Review URL(s) modified (diff)

comment:10 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5215 - Inconsistent string needs updating

comment:11 Changed 2 years ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 2 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The correct text now reads:

"Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the Allow some nonintrusive advertising option."

adblockplussbrowser-release-signed-2
Galaxy S7
Android 7.0

Note: See TracTickets for help on using tickets.