Opened 3 months ago

Closed 2 months ago

Last modified 2 weeks ago

#5220 closed change (fixed)

Update lib/io.js for chrome add-on

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: trev Blocked By:
Blocking: #5094 Platform: Chrome
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29433625

Description (last modified by hfiguiere)

Background

Following #5059, we change the io.js API to use promises in libadblockpluschrome

This will import the following changes:

  • #5059 - Simplify I/O API and FilterStorage implementation
  • #5153 - Simplify patterns.ini parsing
  • #4796 - Use a modern JS engine in the browser tests and convert all files to ECMAScript 6
  • Misc test fixes.

What to change

  • Bump dependencies for core
  • Modify lib/io.js to return promise where needed

Change History (10)

comment:1 Changed 3 months ago by hfiguiere

  • Cc trev added

comment:2 Changed 3 months ago by hfiguiere

This needs to be done for issue #5094 as this changes are in core already.

comment:3 Changed 3 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 months ago by trev

  • Description modified (diff)

comment:5 Changed 3 months ago by trev

If this is a dependency update, it should list all changes being imported and their implications. This way we make sure that we know which changes go into a milestone (only this issue will be listed there, not the issues you are importing) and that testers know what needs to be tested. You can see this in #3957 and #3835 for example.

comment:6 Changed 3 months ago by hfiguiere

  • Description modified (diff)

comment:7 Changed 2 months ago by abpbot

A commit referencing this issue has landed:
Issue 5220 - Update the IO API

comment:8 Changed 2 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 2 months ago by hfiguiere

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next

comment:10 Changed 2 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. IO related functionality like filter storage seems okay.

ABP 1.13.2.1785
Chrome 49 / 59 / Windows 7
Opera 37 / 45 / Windows 7

Note: See TracTickets for help on using tickets.