Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#5237 closed defect (fixed)

Correct filter lists not applied on other language installation

Reported by: scheer Assignee: jwangenheim
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.2
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: diegocarloslima, jwangenheim, tpregueiro, mario Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29505565/

Description (last modified by jwangenheim)

When the user installs ABP for Samsung Internet in any other language other than English, the correct corresponding language filter list should be applied (and not just the default English filter list).

Environment

adblockplussbrowser-release-signed-2
Galaxy S7
Android 7.0

How to reproduce

  1. Change device language to French
  2. Install ABP for Samsung Internet

Observed behaviour

English language filter list is applied.

Expected behaviour

French language filter list is applied.

If the user starts the app for the first time, we force to update the subscription which was selected as the default, no matter if he has a WIFI connection or not. From the second start we only update when the user has a WIFI connection.
To make sure the users have at least one working filter list after they installed the app, we keep the bundled EasyList. If the download fails or English is selected as default, the bundled list will be used.

We'll need to mach the prefixes attr in subscriptions.xml with the current Locale, on first launch, in order to select the most appropriate filter list. If no match is found, it should default to easylist. It might be required to tweak with the codes for proper mapping (e.g. Hebrew code is he in subscriptions.xml while the Android locale code is iw).

Change History (14)

comment:1 Changed 3 years ago by diegocarloslima

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 2 years ago by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed 2 years ago by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from reviewing to reopened

comment:5 Changed 2 years ago by jwangenheim

I started to work on that issue and the default subscription is selected according to the device language now. But that leads us to another problem. Per default no filter list updates were made on mobile connection, so if a user installs the app on mobile connection and i.e. the german filter list is selected as the default subscription it will not be updated (and stay empty) until he has a WIFI connection.

I would like to suggest two different approaches to solve this problem:

  1. We delete the bundled EasyList what will reduce the APK size about approx. 0.6 mb and if the user starts the app for the first time, we force to download the subscription which was selected as the default, no matter if he has a WIFI connection or not. From the second start we only update when the user has a WIFI connection.
  1. We keep the bundled EasyList and enable it as default, no matter which device language was selected. In addition we select the most appropriate filter list for the users current locale. The update of the second filter list will be performed if the user has a WIFI connection.

comment:6 Changed 2 years ago by jwangenheim

  • Cc LawannaURR tpregueiro added; mario removed

comment:7 Changed 2 years ago by mario

  • Cc mario added

comment:8 Changed 2 years ago by jwangenheim

  • Cc LawannaURR removed

comment:9 Changed 2 years ago by jwangenheim

  • Description modified (diff)

comment:10 Changed 2 years ago by jwangenheim

  • Description modified (diff)

comment:11 Changed 2 years ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:13 Changed 2 years ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 2 years ago by rscott

  • Verified working set
Note: See TracTickets for help on using tickets.